Implement Decode, Encode and Type for Box, Arc, Cow and Rc
#3674
Conversation
joeydewaal
changed the title
Decode, Encode and Type for Box, Arc, Cow and Rc
@joeydewaal technically it's still possible to use by getting the We can relax the sqlx/sqlx-core/src/query_as.rs Line 111 in 277dd36 |
joeydewaal
force-pushed
the
encode-decode
branch
from
676e11e to
f2930a6
Compare
|
Makes sense, I added the impl for |
|
CI should be fixed if you rebase. |
joeydewaal
force-pushed
the
encode-decode
branch
from
9d694c0 to
b6521ae
Compare
joeydewaal
force-pushed
the
encode-decode
branch
9 times, most recently
from
b59de52 to
3857c69
Compare
joeydewaal
force-pushed
the
encode-decode
branch
2 times, most recently
from
608908c to
c68cf4b
Compare
joeydewaal
force-pushed
the
encode-decode
branch
3 times, most recently
from
eb5b015 to
2da2978
Compare
joeydewaal
force-pushed
the
encode-decode
branch
from
2da2978 to
bf09881
Compare
|
Right, that should be reflected in the latest changes. |
| impl<'r, 'a, DB> Decode<'r, DB> for Cow<'a, str> | ||
| where | ||
| DB: Database, | ||
| String: Decode<'r, DB>, | ||
| { | ||
| fn decode(value: <DB as Database>::ValueRef<'r>) -> Result<Self, BoxDynError> { | ||
| <String as Decode<DB>>::decode(value).map(Cow::Owned) | ||
| } | ||
| } | ||
|
|
||
| impl<'r, 'a, DB> Decode<'r, DB> for Cow<'a, [u8]> | ||
| where | ||
| DB: Database, | ||
| Vec<u8>: Decode<'r, DB>, | ||
| { | ||
| fn decode(value: <DB as Database>::ValueRef<'r>) -> Result<Self, BoxDynError> { | ||
| <Vec<u8> as Decode<DB>>::decode(value).map(Cow::Owned) | ||
| } | ||
| } |
There was a problem hiding this comment.
I think these aren't necessary if you add T: ?Sized to the generic impl.
fixes #3100
Implements
Decode,EncodeandTypeforBox<T>,Arc<T>,Cow<'_,T>andRc<T>. I left out theDecodeimpl forRc<T>because of theSendtrait bounds inQueryAsandQueryScalar(which makes it impossible to useRc).